(4/n) Make log handler async #485
Closed
+427
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78028382 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
9a227e1 to
510bff6
Compare
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
510bff6 to
9fe8605
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78028382 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Pull Request resolved: pytorch-labs#485 Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
9fe8605 to
02ca8c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78028382 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Pull Request resolved: pytorch-labs#485 Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
02ca8c0 to
288081b
Compare
Summary: Different alloc should have different setup of state actor. The remote allocator should bootstrap the state actor inside the initializer. This will be done in the follow-up diffs. Differential Revision: D77914042
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
288081b to
c5b43fc
Compare
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
c5b43fc to
cf26909
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78028382 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 10, 2025
Summary: Pull Request resolved: pytorch-labs#485 Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
highker
force-pushed
the
export-D78028382
branch
from
cf26909 to
d7a9bee
Compare
Summary: Pull Request resolved: pytorch-labs#485 Forgot to anonotate with async_trait thus having the issue before Reviewed By: shayne-fletcher, kaiyuan-li Differential Revision: D78028382
|
This pull request was exported from Phabricator. Differential Revision: D78028382 |
highker
force-pushed
the
export-D78028382
branch
from
d7a9bee to
34805b7
Compare
|
This pull request has been merged in 1e8e202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Forgot to anonotate with async_trait thus having the issue before
Reviewed By: shayne-fletcher
Differential Revision: D78028382